Modify terminal tab bar location in titlebar
Mitchell
Hashimoto • @mitchellh
8mo agoWhat if we changed the @macos/Sources/Features/Terminal/Window Styles/TitlebarTabsTahoeTerminalWindow.swift to make the tab bar a top accessory view rather than a bottom one to make our tabs go into the titlebar?
Looking at the code, changing it to use a top accessory view instead of the current approach wouldn't work well. The current implementation doesn't use layoutAttribute = .bottom - it uses .right (line 59) and then manually repositions the tab bar into the toolbar using constraints.
To move tabs into the titlebar above the toolbar, you'd want:
- Change
layoutAttribute = .rightto.top(line 59) - Remove the constraint-based repositioning logic (lines 123-153)
- Adjust
fullSizeContentView = trueif not already set - Handle the window button overlap differently
However, this approach has tradeoffs:
- Top accessory: Tabs sit above the titlebar (macOS default), creating a separate visual layer
- Current approach: Tabs are embedded within the titlebar itself, creating a unified appearance like Safari
The current implementation gives you the integrated titlebar tabs look. A top accessory would feel more like a traditional tabbed window. Which style are you aiming for?
Let's try a top accessory
Edited TitlebarTabsTahoeTerminalWindow.swift
+1
-58
Done! Changed to use .top layout and removed the constraint manipulation that was embedding tabs into the toolbar. The tabs will now appear as a standard top accessory view above the titlebar.