Sign In Sign Up

Make iconName optional in UpdateViewModel

Mitchell
Mitchell Hashimoto • @mitchellh
 7mo ago
ghostty-org/ghostty
Change `iconName` in @macos/Sources/Features/Update/UpdateViewModel.swift to be an optional, return nil for blank. Update usage.

Done. Changed iconName to String? returning nil for blank states, and updated UpdateBadge.swift to handle the optional with if let bindings.

Unify `text` and `tooltip`. They seem almost identical and I think could serve the same use.

Done. Removed stateTooltip and updated text to show the localized error description for error states. UpdatePill.swift now uses text for both display and tooltip.

Add docs for the various computed properties in @macos/Sources/Features/Update/UpdateViewModel.swift
Edited UpdateViewModel.swift
Edited UpdateViewModel.swift
Edited UpdateViewModel.swift
Edited UpdateViewModel.swift
Edited UpdateViewModel.swift
Explored 1 file
Edited UpdateViewModel.swift
+8

Done. Added documentation for all five computed properties in UpdateViewModel.swift.