Sign In Sign Up

Complete TODOs in systematic workflow

Nic
Nic Wise • @fastchicken
 7mo ago
nicwise/rucord main
There are a number of incomplete TODOs in @todo.md Can you complete them, one by one, doing the following * implement the todo * make sure the app builds * wait until I check it in the simulator * when I'm happy with it, mark it complete in @todo.md, commit and push to git * And then do the next one in the same way

Update

  • Implemented the Add Car image picker to mirror the Edit Car flow in the Views.swift:
    • Shows “Add Photo” when no image is selected.
    • Shows a thumbnail and a “Remove Photo” button when an image is selected.
    • Removed an unused showingImagePicker state.
  • App build succeeded via Xcode command line.

What I need from you

  • Please run the app in the simulator and verify the Add Car image picker now behaves the same as the Edit Car screen.

Next steps

  • Once you confirm, I’ll mark the item complete in TODO.md, commit, and push.
looks good, but can you change both places (add and edit card) to have: * in Add state, its perfect as it is. No change * when an image has been picked, show a crop of the image the full width of the cell, with "Remove photo" (and an icon) in a seperte cell below. functionally the same - press remove, and it goes back to the add state.

Update

  • Adjusted both Add and Edit screens in Views.swift and (file:///Users/nic/code/mine/rucord/Rucord/Views.swift#L410-L469):
    • Add Car:
      • No-image state unchanged: shows “Add Photo” row.
      • When an image is selected, shows a full-width cropped image row, and a separate “Remove Photo” row with an icon beneath it.
    • Edit Car (while editing):
      • Matches the same pattern: full-width image row when present, and a separate “Remove Photo” row below; otherwise shows “Add Photo”.
  • Kept functional behavior identical: tapping Remove clears the image (in Edit, it uses the existing “empty UIImage” sentinel as before).
  • Built with Xcode; build succeeded.

What I need from you

  • Please test in the simulator:
    • Add Car: pick an image → confirm full-width image row + separate “Remove Photo” row, then remove → returns to Add state.
    • Edit Car: same behavior while in Edit mode.

When you’re happy, I’ll mark the TODO complete in TODO.md, commit, and push.

perfect, but can you make the icon next to "Remove photo" be red, to match the text and not blue

Update

  • Set the Remove Photo button’s icon to red in both places so it matches the text:
  • Build succeeded.

Please verify

  • In both Add and Edit (editing mode): when an image is shown, “Remove Photo” text and icon should both be red. Confirm and I’ll mark the TODO done, commit, and push.
thanks - that looks good. On to the next one

Update

  • Implemented 14-days-left notifications and app badge:
    • On launch, the app requests notification permission and schedules a local notification for each car 14 days before projected RUC expiry.
    • When due, a notification fires with sound and sets a badge.
    • Opening the app clears delivered notifications and resets the badge to 0.
  • Changes in:
  • Also marked the previous image picker TODO as done in TODO.md and pushed to main.

How to test

  • Allow notifications when prompted.
  • Ensure a car has enough history for a projected expiry date.
  • Adjust dates/odometer so one car’s projected expiry is within 14 days to trigger an immediate notification; otherwise, it schedules for the correct future day at 9:00.

Next steps

  • Please verify the notification appears when a car is within 14 days and that the icon badge clears on opening the app. When confirmed, I’ll mark the TODO complete and push.
I appear to be getting this. is this something which needs fixing? load_eligibility_plist: Failed to open /Users/nic/Library/Developer/CoreSimulator/Devices/A25E97A2-7FC4-4E48-9112-EBB887484E30/data/Containers/Data/Application/3B45696B-2290-4259-A09D-2ACBE2FC53D3/private/var/db/eligibilityd/eligibility.plist: No such file or directory(2)

About that simulator message

  • That line is a benign Simulator warning from a system daemon (eligibilityd) trying to read a non-existent plist. It’s not caused by our code and can be ignored.
  • If it’s noisy:
    • Simulator → Settings → Erase All Content and Settings (or create a new simulator).
    • Quit and relaunch the Simulator.
    • Run on a physical device (you won’t see it).

Next

  • Were you able to verify the 14‑day notification and app badge behavior? If yes, I’ll mark the TODO complete and push. If not, tell me what you saw and I’ll tweak the scheduling.
I can see how the code works, and I can see it saying its set an alert, but I never see the alert happen

What I changed

  • Added a notification delegate so alerts show while the app is in the foreground:
    • The delegate presents banner, list, sound, and badge when a notification fires.
    • Set as the UNUserNotificationCenter delegate during setup.
  • Switched badge clearing to the modern API.
  • Files changed:

Build succeeded.

How to verify

  • Launch the app, allow notifications.
  • Ensure at least one car is within the 14-day window to trigger the 5-second immediate test path.
  • Keep the app in the foreground and wait ~5 seconds: you should now see a banner. If you background the app, you’ll get the standard notification.
  • Opening the app should clear any badge.
nice, that works. Can we keep the badge on there while there are cars which are near expiry, rather than clearing it when you open the app. And make the counter be the number of cars which are at/near expiry

Update

  • Kept the app badge persistent and set it to the count of cars at/near expiry:
    • Near expiry definition: expired (distanceRemaining == 0) or projected days remaining ≤ 14.
    • On app launch and whenever cars change or app becomes active, the badge is updated to that count.
  • Changes in RucordApp.swift, setup delegate, and new helpers nearExpiryCount/refreshBadgeCount.

Build succeeded.

Please verify

  • Put one or more cars within 14 days (or expired) and background/foreground the app; the badge should reflect the number of such cars and not clear on open. If it looks good, I’ll mark the TODO complete and push.
ok, its showing the alert every time the app is opened. We will need to record the fact that we have made the alert against the car - and when the odo is updated, recompute that. Also make the alert reflect how many days the car has left

Update

  • Stopped repeat alerts on every app open:
    • Track per-car/per-RUC-cycle alerts in UserDefaults using a token: carID + expiryOdometer.
    • When within the 14‑day window, we only schedule an immediate alert if it hasn’t already been sent for this cycle; we mark it as sent immediately to avoid re-alerting on next launch.
    • When scheduled for a future day, we include the token in userInfo; the delegate marks it as alerted when shown or tapped.
  • Notification text now reflects the days remaining:
    • “About X days of RUC remaining for .” or “RUC expired for .”
  • Badge logic unchanged from prior step: shows the count of cars that are expired or ≤14 days; updated on app launch, foreground, and when cars change.

Changed:

Build succeeded.

Please verify

  • Put a car inside 14 days and open the app:
    • You should get one alert once; subsequent opens won’t re-alert for that car until its RUC expiry changes (e.g., you extend expiryOdometer).
    • The alert text shows “About X days …” or “RUC expired …”.
    • The badge equals the number of cars expired or ≤14 days.
looks good. mark as done, commit, push, do the next one.

Status

  • Marked notifications/badge TODO complete in TODO.md.
  • Implemented Delete Car from the edit screen:
    • New delete API in CarStore.swift removes the car and its stored image.
    • Edit view adds a “Danger Zone” section with a destructive “Delete Car” button and confirmation dialog in Views.swift. On confirm it deletes and dismisses.
  • Build succeeded.

Next

  • Please test deleting a car (enter Edit → Delete Car → confirm). If all good, I’ll mark the delete-car TODO done and push.
nice, but make the icon red to match the text
  • Made the “Delete Car” button icon red to match the text in Views.swift.
  • Built the app successfully.

Please confirm in the simulator. If it looks good, I’ll mark the delete-car TODO complete and push.

deleting a car should also update the alerts - the badge didn't change when I deleted a car near expiry
  • Made the Delete Car icon red in Views.swift.
  • Ensured badges/alerts update when cars change, including deletion:
    • On store changes, we already refresh the badge and reschedule.
    • Now we also remove previously scheduled “14 days” notifications and re-schedule for the current set of cars in RucordApp.scheduleRUCNotifications. This clears pending alerts for deleted cars so the badge and future alerts reflect reality.

Build succeeded. Please delete a near-expiry car again; the badge should update immediately. If all good, I’ll mark the delete-car TODO as done and push.

excellent, but it didn't remove the last one - so if there are no cars, it should clear the badge if its thre

Build succeeded. Please delete the last near‑expiry car again; the badge should clear immediately. Ready to mark the delete-car TODO complete and push after your confirmation.

looks good. mark it off, commit, push
  • Marked delete-car TODO complete in TODO.md.
  • Delete flow: confirmation button shows red icon; deleting removes the stored image and the car, and updates notifications/badge immediately via rescheduling and clearing when count is zero.
  • Changes touched:
  • Build succeeded. Pushed commits to main. Ready for the next item.
can you now run an archive, and push it to Test Flight. xcode has my credentials loaded already
Created ExportOptions.plist
+23

Archive and export

  • Archived Release build to build/Rucord.xcarchive.
  • Exported .ipa for App Store Connect to build/export with options in ExportOptions.plist.

Next steps to upload to TestFlight:

  • I can upload the IPA via App Store Connect CLI if you provide either:
    • App Store Connect API Key ID and Issuer (preferred), or
    • Your Apple ID email plus the keychain password item name (e.g. @keychain:AC_PASSWORD).
  • Alternatively, open Xcode → Window → Organizer → Archives → Distribute App → App Store Connect → Upload, and it will use your saved Xcode credentials.

Your IPA is at build/export/Rucord.ipa. Want me to upload using an API key?